Shop OBEX P1 Docs P2 Docs Learn Events
An Issue with REP blocks, Single step interrupts and HUB execution - Page 3 — Parallax Forums

An Issue with REP blocks, Single step interrupts and HUB execution

13»

Comments

  • cgraceycgracey Posts: 14,152
    ozpropdev wrote: »
    Seairth wrote: »
    Does it work for D>1 and the last instruction in the REP block is a JMP? (I can't look at your test code at the moment.)
    I had tested for D>1 which worked OK, but in all my tests I hadn't tried JMP as the last instruction in the block.
    Your onto something there Seairth, it seems that if the last instruction is a JMP the issue raises it's head again.
    I'll keep digging....

    We could just have a rule that no branches are allowed within a REP block.
  • IIRC to switch execution modes it's enough to JMP in the right (address) execution space, isn't it?
    In this case I think that every REP loop (I mean in every exec mode) has to be tested for both cases, JMP into same mode and JMP into different mode.
    cgracey wrote: »
    We could just have a rule that no branches are allowed within a REP block.
    Isn't (conditional) JMP within REP an efficient way to replicate "do-until" or "do-while" structures with timeout (max count at given clock)?

  • cgracey wrote: »
    We could just have a rule that no branches are allowed within a REP block.
    That would simplify things

  • dMajo wrote: »
    In this case I think that every REP loop (I mean in every exec mode) has to be tested for both cases, JMP into same mode and JMP into different mode.
    All of my REP tests did just that.
    Three different tests, jump to the same exec mode and jump to the other two modes.


  • cgraceycgracey Posts: 14,152
    dMajo wrote: »
    IIRC to switch execution modes it's enough to JMP in the right (address) execution space, isn't it?
    In this case I think that every REP loop (I mean in every exec mode) has to be tested for both cases, JMP into same mode and JMP into different mode.
    cgracey wrote: »
    We could just have a rule that no branches are allowed within a REP block.
    Isn't (conditional) JMP within REP an efficient way to replicate "do-until" or "do-while" structures with timeout (max count at given clock)?

    It's slightly more efficient than a branching loop, as the loop is automatic, but it's really valuable for repeating just a few instructions, since that's where overheadless looping makes a significant difference.
  • Instead of cancelling a REP block with a JMP instruction what about a "QUIT" instruction that cancels the REP block and simply ignores any remaining instructions in the block (treats remaining instructions as NOP's).
  • evanhevanh Posts: 15,915
    Chip's got a point. While it's nice to have the option of conditions, the moment they are added then a regular loop construct may as well be used instead.
  • evanhevanh Posts: 15,915
    The only solid reason I can think of breaking a REP is for interrupts, but that would also need the ability to subsequently resume the REP.
  • SeairthSeairth Posts: 2,474
    edited 2017-01-27 11:47
    ozpropdev wrote: »
    Instead of cancelling a REP block with a JMP instruction what about a "QUIT" instruction that cancels the REP block and simply ignores any remaining instructions in the block (treats remaining instructions as NOP's).

    Actually, QUIT (REXIT?) could use the same encoding as REP #0, #0! In other words, if there's an active REP, QUIT NOP's the remaining instructions. If there's not an active REP, it's just a NOP itself.
  • cgraceycgracey Posts: 14,152
    Seairth wrote: »
    ozpropdev wrote: »
    Instead of cancelling a REP block with a JMP instruction what about a "QUIT" instruction that cancels the REP block and simply ignores any remaining instructions in the block (treats remaining instructions as NOP's).

    Actually, QUIT (REXIT?) could use the same encoding as REP #0, #0! In other words, if there's an active REP, QUIT NOP's the remaining instructions. If there's not an active REP, it's just a NOP itself.

    Good point. Doing a 'REP #0, S/#' would turn REP off. We could have an assembler alias, "REPQ" that is really "REP #0,#0".
  • RaymanRayman Posts: 14,641
    Maybe we figured out a long time ago that jumping out of a REP loop was too much trouble to deal with?

    This sounds like adding new features to me, which I wish we'd stop doing...
  • cgraceycgracey Posts: 14,152
    Rayman wrote: »
    Maybe we figured out a long time ago that jumping out of a REP loop was too much trouble to deal with?

    This sounds like adding new features to me, which I wish we'd stop doing...

    Maybe we did. I don't remember. I'm just trying to make it work right.
  • cgracey wrote: »
    Seairth wrote: »
    ozpropdev wrote: »
    Instead of cancelling a REP block with a JMP instruction what about a "QUIT" instruction that cancels the REP block and simply ignores any remaining instructions in the block (treats remaining instructions as NOP's).

    Actually, QUIT (REXIT?) could use the same encoding as REP #0, #0! In other words, if there's an active REP, QUIT NOP's the remaining instructions. If there's not an active REP, it's just a NOP itself.

    Good point. Doing a 'REP #0, S/#' would turn REP off. We could have an assembler alias, "REPQ" that is really "REP #0,#0".

    Except, in this case, I think REPQ should also NOP the remaining instructions in the REP block.
Sign In or Register to comment.