New DIR/OUT bit-level instructions
cgracey
Posts: 14,134
While writing the ROM code, it was quite frustrating to keep track of which port various pins were on, as operations to a pin's DIR/OUT bits need to know DIRA/DIRB and OUTA/OUTB. Conveniently, the smart pin instructions work solely from the pin number, which is very straightforward.
I have wanted instructions that can manipulate a pin's DIR/OUT bits by the pin number for quite a while, but I figured the timing would be impossible when it came to the data forwarding circuitry. I realized tonight that it's not a problem, actually, because we have result-write redirection circuitry and those DIR/OUT bits are always available from their flops, unlike the cog RAM.
It turned out to be quite a simple matter to add instructions that manipulate the DIR/OUT bits via the pin number, and support data-forwarding, as well. On the Cyclone V, it only added 42 ALM's to each cog.
Here are the new instructions:
These instructions simplify code quite a bit, especially when you are using smart pins.
I have wanted instructions that can manipulate a pin's DIR/OUT bits by the pin number for quite a while, but I figured the timing would be impossible when it came to the data forwarding circuitry. I realized tonight that it's not a problem, actually, because we have result-write redirection circuitry and those DIR/OUT bits are always available from their flops, unlike the cog RAM.
It turned out to be quite a simple matter to add instructions that manipulate the DIR/OUT bits via the pin number, and support data-forwarding, as well. On the Cyclone V, it only added 42 ALM's to each cog.
Here are the new instructions:
CCCC 1101011 ZCL DDDDDDDDD 001000000 DIRL D/# (pin D/# DIR bit = 0, IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001000001 DIRH D/# (pin D/# DIR bit = 1, IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001000010 DIRC D/# (pin D/# DIR bit = C, IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001000011 DIRNC D/# (pin D/# DIR bit = !C, IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001000100 DIRZ D/# (pin D/# DIR bit = Z, IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001000101 DIRNZ D/# (pin D/# DIR bit = !Z, IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001000110 DIRN D/# (pin D/# DIR bit = !, IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001000111 TESTIN D/# (pin D/# IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001001000 OUTL D/# (pin D/# OUT bit = 0, IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001001001 OUTH D/# (pin D/# OUT bit = 1, IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001001010 OUTC D/# (pin D/# OUT bit = C, IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001001011 OUTNC D/# (pin D/# OUT bit = !C, IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001001100 OUTZ D/# (pin D/# OUT bit = Z, IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001001101 OUTNZ D/# (pin D/# OUT bit = !Z, IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001001110 OUTN D/# (pin D/# OUT bit = !, IN bit -> C/NZ) CCCC 1101011 ZCL DDDDDDDDD 001001111 TESTNIN D/# (pin D/# IN bit -> NC/Z)
These instructions simplify code quite a bit, especially when you are using smart pins.
Comments
I also made some instructions to trigger interrupts, regardless of events: TRGINT1/TRGINT2/TRGINT3. I needed these in my auto-baud detector ISR, to be sure that the serial-receive ISR always executes after a re-frame. In some cases, people will find them necessary to keep things in order when multiple events are triggering and you want to be sure that an ISR executes.
Yeah, I was thinking that this A/B matter was going to frustrate people and demotivate them. It was making things quite unpleasant.
There are some cases where I'd have to add an instruction to operate on more than one pin, but I think that's worth it to have it easier to move between ports.
Looks good.
Are there not already some Boolean opcodes ?
Would it make sense to follow a more common mnemonic approach to bit-level opcodes.
EDIT: perhaps dirh becomes setdir and outl becomes clrout etc
@Chip: I don't think this would be possible but when I do an OUT I certainly would like the DIR set accordingly and automatically which I normally have to handle with another instruction.
Prop2-Hot did both, but logic was no object. Neither was power.
Couldn't hoit to ask and it might have been a "yeah sure, no problems" though that didn't seem probable. I had been thinking of actual hardware between the OUT and DIR to effect this though.