I'm not sure if you're maintaining a three pin version of your code or not but I noticed a shortcut you took to set the pin directions which doesn't allow a user to easily change the pin configuration of there setup.
At the beginning of the PASM section you have:
DAT org
asm_entry mov dira,#7 'make pin 0, 1, 2 pin an output
Since you have the pin mask hard coded with the number 7, if someone changes the constants it won't have any effect on which pins are set to outputs.
CON CLK = 2 'pin for clock (P2)
LAT = 1 'pin for latch (P1)
SER = 0 'pin for serial (P0)
In case anyone else is using the 3-pin version of the code here's the fix.
DAT org
asm_entry 'mov dira,#7 'make pin 0, 1, 2 pin an output
'mov outa,#0 'set all pins to off
or dira, SERpin 'set needed pins to output (added by DWD)
or dira, CLKpin '(added by DWD)
or dira, LATpin '(added by DWD)
I commented out the line setting the pins to off since it's not needed.
The demo program has a problem if the buffer isn't long aligned. Anyone using this code in a project ought to take a look at this post in the 1-pin thread about how to make the buffer long aligned.
Anyone coming across this thread to learn about how to use the 16-segment display on the PPDB should also look at the 1-pin thread to see the latest discussion on the topic.
I have a lower case alphabet I will likely add to Tony's code and I'll be posting it in the 1-pin thread.
Thanks again Tony for making these boards. They're a lot of fun. The board and your code sure make it easy to use the display.
Comments
Tony,
I'm not sure if you're maintaining a three pin version of your code or not but I noticed a shortcut you took to set the pin directions which doesn't allow a user to easily change the pin configuration of there setup.
At the beginning of the PASM section you have:
Since you have the pin mask hard coded with the number 7, if someone changes the constants it won't have any effect on which pins are set to outputs.
CON CLK = 2 'pin for clock (P2) LAT = 1 'pin for latch (P1) SER = 0 'pin for serial (P0)In case anyone else is using the 3-pin version of the code here's the fix.
DAT org asm_entry 'mov dira,#7 'make pin 0, 1, 2 pin an output 'mov outa,#0 'set all pins to off or dira, SERpin 'set needed pins to output (added by DWD) or dira, CLKpin '(added by DWD) or dira, LATpin '(added by DWD)I commented out the line setting the pins to off since it's not needed.
The demo program has a problem if the buffer isn't long aligned. Anyone using this code in a project ought to take a look at this post in the 1-pin thread about how to make the buffer long aligned.
Anyone coming across this thread to learn about how to use the 16-segment display on the PPDB should also look at the 1-pin thread to see the latest discussion on the topic.
I have a lower case alphabet I will likely add to Tony's code and I'll be posting it in the 1-pin thread.
Thanks again Tony for making these boards. They're a lot of fun. The board and your code sure make it easy to use the display.